Topic: Unofficial Patch for Starfleet Command: Orion Pirates  (Read 16838 times)

0 Members and 4 Guests are viewing this topic.

Offline TarMinyatur

  • Lt.
  • *
  • Posts: 938
  • Gender: Male
Unofficial Patch for Starfleet Command: Orion Pirates
« on: November 19, 2015, 12:54:10 am »
Through lots of labor, hex editors, and a disassembler, we have been editing Orion Pirates to fix bugs and to allow for much greater customization of the game than previously thought possible without the source code. The resulting software is not authorized by anyone and shall be freely distributed. The unofficial executable and other assets are useless without a working copy of Orion Pirates 2.552, which you may download from the Dynaverse Marketplace if you've lost your CD. (Similar editing has already been done on Starfleet Command: Community Edition 2.677.)

Patch 2.560 for OP fixes these bugs:

Suicide OL Fusion Beams can no longer be fired in futility beyond OL range (default is 8.99k)
OL/SOL Fusion Beams can do damage at range 8.01k to 8.99k
Phaser-G2 damage estimator displays max-min, instead of min-min

Download the 2.560 Beta. There is a link to the latest version at the top of the General Forum.

« Last Edit: April 18, 2017, 04:02:10 am by TarMinyatur »

Offline Sirgod

  • Whooot Master Cattle Baron
  • Global Moderator
  • Vice Admiral
  • *
  • Posts: 27844
  • Gender: Male
Re: Unofficial Patch for Starfleet Command: Orion Pirates
« Reply #1 on: November 19, 2015, 01:46:53 am »
Woot!
"You cannot exaggerate about the Marines. They are convinced to the point of arrogance, that they are the most ferocious fighters on earth - and the amusing thing about it is that they are."- Father Kevin Keaney, Chaplain, Korean War

Offline TAnimaL

  • Lt.
  • *
  • Posts: 772
  • Gender: Male
    • Combat Logs from the Cold Depths of Space
Re: Unofficial Patch for Starfleet Command: Orion Pirates
« Reply #2 on: November 19, 2015, 08:32:58 am »
Tar, what number should this patch use, just so we can all call it the same thing. 2.5.5.3 or 2.5.5.4? (Being next after 2.5.5.2)

Moving forward, if there is a another, more significant patch, should we call that 2.6.0.1, just to differentiate it?

Offline TarMinyatur

  • Lt.
  • *
  • Posts: 938
  • Gender: Male
Re: Unofficial Patch for Starfleet Command: Orion Pirates
« Reply #3 on: November 19, 2015, 10:01:56 am »
We can call the vanilla patch 2.560. The 2.5xx series has always been reserved for OP. The 2.6xx series (2.660, 2.670, 2.673) is dedicated to CE.

2.560 is fresh territory, with room for 39 revisions.
« Last Edit: November 19, 2015, 04:28:44 pm by TarMinyatur »

Offline TAnimaL

  • Lt.
  • *
  • Posts: 772
  • Gender: Male
    • Combat Logs from the Cold Depths of Space
Re: Unofficial Patch for Starfleet Command: Orion Pirates
« Reply #4 on: November 19, 2015, 11:00:18 am »
Thanks Tar. I agree on that 2560 idea.

I copied the PhA/B ranges from the literature (manuals etc), were those brackets wrong? At my work pc, no time to play now. Wait, I shouldn't even be checking this site. Arrgg! Damn, this is so tempting!!

Offline d4v1ks

  • D.Net VIP
  • Lt.
  • *
  • Posts: 788
  • Gender: Male
Re: Unofficial Patch for Starfleet Command: Orion Pirates
« Reply #5 on: November 19, 2015, 11:11:19 am »
TAnimaL, I've attached an edited copy of your latest offsets.txt. I've commented out the 2.561 stuff that requires new variables. Everything else will work on 2.552. I adjusted the Ph-A/B comments to match the brackets. Please test it.

Tar, my sfc editor says that some offsets' data structures are overlapping! Need to check that!  :police:

Humm... occurred me the ideia. If you wish i could add into the offsets file a way to upgrade 2552... Its not hard. People would only need the sfc editor and offsets.txt with the fixes! They would be hable to download a all-in-one!

I can add an option to compare 2 versions and produce the patch.
Then in the offsets.txt, people would see something in this style, and be hable to switch between vannila or the new version in the UI !! Could do even better.

<< Version 2552
81 C1 64 02 00 00 8B 45  FC 8B 90 64 02 00 00 8B B0
42 30 FF D0 50 6A 08 8B  4D FC E8 91 FB 1E 00 50  B0
81 C1 64 02 00 00 8B 45  FC 8B 90 64 02 00 00 8B B0
42 30 FF D0 50 6A 08 8B  4D FC E8 91 FB 1E 00 50  B0

<< Version 2560
81 C1 64 02 00 00 8B 45  FC 8B 90 64 02 00 00 8B B0
42 30 FF D0 50 6A 08 8B  4D FC E8 91 FB 1E 00 50  B0
81 C1 64 02 00 00 8B 45  FC 8B 90 64 02 00 00 8B B0
42 30 FF D0 50 6A 08 8B  4D FC E8 91 FB 1E 00 50  B0
« Last Edit: November 19, 2015, 11:29:10 am by d4v1ks »
"But he isn't wearing anything at all!" (The Emperor's New Clothes)

Offline TAnimaL

  • Lt.
  • *
  • Posts: 772
  • Gender: Male
    • Combat Logs from the Cold Depths of Space
Re: Unofficial Patch for Starfleet Command: Orion Pirates
« Reply #6 on: November 19, 2015, 11:12:26 am »
(I swear, one more thing then back to work....)

For anyone using this current offset, it creates a tab in SFC_Editor for mines with 5 different entries for "Large Explosive Mine." NONE of those entries are correct thoughl changing them will not change mine explosions, and might be changing something else somewhere. Sorry, I must have uploaded my workbin copy last time. Will correct later.

d4v1ks, those overlaps (probably) don't matter - there are some repeated entries in the offset i uploaded, see above. For example, one of those overlaps is that I have two entreis going to the same float, for the Type-I missille and the offensive plasma-Ds on the D rack.

Offline TarMinyatur

  • Lt.
  • *
  • Posts: 938
  • Gender: Male
Re: Unofficial Patch for Starfleet Command: Orion Pirates
« Reply #7 on: November 19, 2015, 12:00:36 pm »
Looking at the latest offsets.txt, I determined that the Cloak Adjustment needs to be isolated. It can't be included in vanilla because its data (50.0d) is shared with T-bomb placement range and other stuff. I've isolated it in 2.561.

The AMD bracket offset is incorrect, resulting in overlapped memory.

455AEC: 4f // AMD brackets, range x10 // 5.0, 20.0, 30.0, 40.0
//455AF0: 4f // Error! AMD brackets, range x10 // 10.0, 20.0, 30.0, 40.0

That will fix it.
« Last Edit: November 19, 2015, 08:49:07 pm by TarMinyatur »

Offline TarMinyatur

  • Lt.
  • *
  • Posts: 938
  • Gender: Male
Re: Unofficial Patch for Starfleet Command: Orion Pirates
« Reply #8 on: November 19, 2015, 12:35:19 pm »
I copied the PhA/B ranges from the literature (manuals etc), were those brackets wrong?

The brackets in the literature are wrong, or the data is wrong. The difference is significant, but usually minor, except for Range-1 Phaser-B's (they have a base chance to hit of 83%, instead of 100% as implied by the manual/wiki).

0-1, 2-4, 5-6, 7-10, 11-16, 17-20, 21-24, 25-31, 32-41 // literature

0, 1-3, 4-5, 6-9, 10-15, 16-19, 20-23, 24-30, 31-40 // .exe data

I prefer to not alter the Phaser-A/B data after 14 years.

Offline TAnimaL

  • Lt.
  • *
  • Posts: 772
  • Gender: Male
    • Combat Logs from the Cold Depths of Space
Re: Unofficial Patch for Starfleet Command: Orion Pirates
« Reply #9 on: November 20, 2015, 07:54:11 am »
Well, of course the exe data was correct. I ran a test on the PhA and the damage matches those brackets (0, 1-3, 4-5, 6-9, 10-15, 16-19, 20-23, 24-30, 31-40). It's a little interesting that the manuals per se were wrong about original weapons that were created for OP and not from SFB. I'd guess someone writing that literature copyied the data out of the exe and forgot about the 0.99/-0.01 thingy in the ranges.

Not a high priority but I guess I'll update that weapons wiki soon.

Offline TarMinyatur

  • Lt.
  • *
  • Posts: 938
  • Gender: Male
Re: Unofficial Patch for Starfleet Command: Orion Pirates
« Reply #10 on: November 20, 2015, 12:14:46 pm »
...i could add into the offsets file a way to upgrade 2552... Its not hard. People would only need the sfc editor and offsets.txt with the fixes! They would be hable to download a all-in-one!

Sounds good. It needs to be simple. I think a direct download of 2.560 is good for those who don't intend to customize any values.

Offline TAnimaL

  • Lt.
  • *
  • Posts: 772
  • Gender: Male
    • Combat Logs from the Cold Depths of Space
Re: Unofficial Patch for Starfleet Command: Orion Pirates
« Reply #11 on: November 21, 2015, 11:40:11 am »
For this patch, and with the PhA/B, we should use range brackets from the exe and ignore (& change) the data in manuals. But for the TR beams, should we use the SFB range brackets (0-3, 4-5, 6-8, 9-12, 12-18 19-26) or the brackets that were in the original exe (0-2, 3-4, 5-7, etc)?  I vote for the true SFB brackets but I didn't want to just assume everyone else did too. Both of these and the advanced phasers are in limited use anyway.

Offline Klingon Fanatic

  • Lt. Commander
  • *
  • Posts: 2070
  • Gender: Male
Re: Unofficial Patch for Starfleet Command: Orion Pirates
« Reply #12 on: November 21, 2015, 12:16:23 pm »
First of all, thanks to all of you guys for working on this.

Second, I tried to reinstall SFC: OP on my Windows 10 Laptop and I can get the 2560 number to appear on the start up screen but the game hangs after I click single player skirmish or even multiplayer.

Any advise on how to get this game to work on Windows 10?
HoD Radjekk Vor Thruum
IKV Kraag Dorr
SuvwI' Qeh KCC
Commander, Task Force Kraag Dorr's Teeth First Strike Squadron

Offline TAnimaL

  • Lt.
  • *
  • Posts: 772
  • Gender: Male
    • Combat Logs from the Cold Depths of Space
Re: Unofficial Patch for Starfleet Command: Orion Pirates
« Reply #13 on: November 21, 2015, 01:59:42 pm »
Here's what d4v1ks did, as mentioned in the "Win8.1" thread
http://www.dynaverse.net/forum/index.php/topic,163393826.msg1123050876.html#msg1123050876

Have you tried  2552 OP in Win10 yet?

Offline TarMinyatur

  • Lt.
  • *
  • Posts: 938
  • Gender: Male
Re: Unofficial Patch for Starfleet Command: Orion Pirates
« Reply #14 on: November 21, 2015, 02:04:46 pm »
For this patch, and with the PhA/B, we should use range brackets from the exe and ignore (& change) the data in manuals. But for the TR beams, should we use the SFB range brackets (0-3, 4-5, 6-8, 9-12, 12-18 19-26) or the brackets that were in the original exe (0-2, 3-4, 5-7, etc)?  I vote for the true SFB brackets but I didn't want to just assume everyone else did too. Both of these and the advanced phasers are in limited use anyway.
I am in favor of using the SFB brackets for TR Beams. The default 5-7 bracket, for example, is weird. I think the programmers made an easy mistake -- going from SFB's "8" to an internal value of 80 to a non-inclusive limit of 90.0f to get 8.99k is ripe for error. Default OL Fusion Beams suffer from this mistake too -- SFB "8" became 8.00k, which doesn't include the customary 0.99 extension.

Offline TarMinyatur

  • Lt.
  • *
  • Posts: 938
  • Gender: Male
Re: Unofficial Patch for Starfleet Command: Orion Pirates
« Reply #15 on: November 21, 2015, 02:17:00 pm »
First of all, thanks to all of you guys for working on this.

Second, I tried to reinstall SFC: OP on my Windows 10 Laptop and I can get the 2560 number to appear on the start up screen but the game hangs after I click single player skirmish or even multiplayer.

Any advise on how to get this game to work on Windows 10?

Hmm. I'd try to do at least one skirmish in 2.500, and then patch to 2.552, so we can rule out 2.560 as an issue.

Offline d4v1ks

  • D.Net VIP
  • Lt.
  • *
  • Posts: 788
  • Gender: Male
Re: Unofficial Patch for Starfleet Command: Orion Pirates
« Reply #16 on: November 21, 2015, 02:29:18 pm »
I think he managed to make it work. he suddently disapeared after posting in so many places.
Why would he just gave up after ask something he wanted so much to know?
"But he isn't wearing anything at all!" (The Emperor's New Clothes)

Offline Klingon Fanatic

  • Lt. Commander
  • *
  • Posts: 2070
  • Gender: Male
Re: Unofficial Patch for Starfleet Command: Orion Pirates
« Reply #17 on: November 21, 2015, 03:24:55 pm »
I think he managed to make it work. he suddently disapeared after posting in so many places.
Why would he just gave up after ask something he wanted so much to know?

I was frustrated that I couldn't play the game so I posted twice about this.

I also figured that I would not get an immediate response since there are so few people here compared to the old days....

At any rate, I have always found the folks at Dynaverse.net very helpful and look forward to trying out the solutions recommended.
HoD Radjekk Vor Thruum
IKV Kraag Dorr
SuvwI' Qeh KCC
Commander, Task Force Kraag Dorr's Teeth First Strike Squadron

Offline d4v1ks

  • D.Net VIP
  • Lt.
  • *
  • Posts: 788
  • Gender: Male
Re: Unofficial Patch for Starfleet Command: Orion Pirates
« Reply #18 on: November 21, 2015, 03:29:10 pm »
ok, lets us try to solve it then, if its not is just a hardware/driver related problem.
"But he isn't wearing anything at all!" (The Emperor's New Clothes)

Offline Klingon Fanatic

  • Lt. Commander
  • *
  • Posts: 2070
  • Gender: Male
Re: Unofficial Patch for Starfleet Command: Orion Pirates
« Reply #19 on: November 21, 2015, 04:42:27 pm »
ok, lets us try to solve it then, if its not is just a hardware/driver related problem.

d4v1ks

Thanks again. I'm all set.
HoD Radjekk Vor Thruum
IKV Kraag Dorr
SuvwI' Qeh KCC
Commander, Task Force Kraag Dorr's Teeth First Strike Squadron