Topic: I think I solved the double-fighter bug..

[GDA-S'Cipio]

OK, I've posted updated packs for

Core missions
Total War missions
The whole shebang

though the big one says it still has about 20 minutes to go on the upload

These include Firesoul's fix for the double-fighter bug, plus a host of minor other fixes (incorrect reporting of  some mission results, the stupid routine that named AI ships things like .I.II.III, etc etc)

thanks again FS!
dave

I've never run the total war pack, but I know some have.  Is it absolutely impossible to draft an ally in the Total War pack even if you want to, or does the DV shift just not get mucked up if you happen to draft an enemy as an ally?

-S'Cipio

[NuclearWessels]

<scratches head>

DH .... I think that was one of the "10" patrols , but can't remember which one (Met_NW10PatrolEnemy or Met_NW10PatrolEnemy_tw ??)

Scippy ... the TW pack will only draft your own race on your side, and will only draft from your "worst enemy" for the opposition side

dave

EDIT: the whole shebang seems to have completed uploading now

[FPF-DieHard]

<scratches head>

DH .... I think that was one of the "10" patrols , but can't remember which one (Met_NW10PatrolEnemy or Met_NW10PatrolEnemy_tw ??)

Scippy ... the TW pack will only draft your own race on your side, and will only draft from your "worst enemy" for the opposition side

dave

EDIT: the whole shebang seems to have completed uploading now

Yup, testing now.

Dod you have any patrols that do not start the players in motion?

[NuclearWessels]

Yup, testing now.

Dod you have any patrols that do not start the players in motion?

Damn!  Knew there was something else I wanted to do - I was going to add a setting so admins could turn that off if they wanted to.

I'll add and test that over the next week or so,
Doh!

dave

[FPF-DieHard]

You rock!

What about AI-stripping and base busting?  Have those been fixed? 

Tell me exactly what you need tested, I will get it done.

[NuclearWessels]

You rock!

What about AI-stripping and base busting?  Have those been fixed? 

Tell me exactly what you need tested, I will get it done.

The AI stripping still isn't up to snuff - I've got a fix, but it's a longer term deal (need to change a bunch of things in the way I'm generating AI to get that right, so it will also wind up needing more extensive testing)

I'm pretty sure I fixed the base busting, but will have to go back and double-check - it was in progress, but I can't remember if I finished testing it or not

For the testing, look for anything you remember that bugs ya, make a list, and let me know.   No promises of course, but I'll see what I can do [EDIT: keeping in mind that I can't do much about Hexx ]

dave

[[RK] Castrin]

Great work FS!! 

Karnak, I think FS meant that he wanted the mission developer to modify the script, rather than tamper with it himself.
Just talking out of my ass here but I think FS is very sensitive about designer's rights and didn't want to step on anyone's toes.
NW has been the only scripter posting recently (yourself and Tracey being absent) so he addressed it to NW.
Once again, just my impression but I do not think any insult was intended.

Umm...No.  It's no secret that FS does not like me or EEK scripts and I don't like people that back-stab.

Since he wants only NW scripts updated then I think I'll oblige him.

This community really sucks to see such garbage posted. End of Story.

Not worth my time anymore.

Geeez, did you even read the FIRST post he made?

Now, I'm gonna try to compile as many missions as possible, but can someone get NuclearWessels and Karnak to see this? Thanks.

-- Luc

Karnak, I'm sad you feel it nessisary to post things like this.

 

[FireSoul]

OK, I've posted updated packs for

Core missions
Total War missions
The whole shebang

I'm fetching the missions now, also. Seems that you have your coding hat back well back on now.

[Strafer]

OK, I've posted updated packs for

Core missions
Total War missions
The whole shebang

I'm fetching the missions now, also. Seems that you have your coding hat back well back on now.

...staple gun, anyone? 

[NuclearWessels]

I'm fetching the missions now, also. Seems that you have your coding hat back well back on now.

Nothing like a break to give you a fresh batch of enthusiasm!  Of course, it also doesn't hurt that the mrs is quite distracted setting up some consultancy work right now

dave

[Bonk]

OK, I've posted updated packs for

Core missions
Total War missions
The whole shebang

though the big one says it still has about 20 minutes to go on the upload

These include Firesoul's fix for the double-fighter bug, plus a host of minor other fixes (incorrect reporting of  some mission results, the stupid routine that named AI ships things like .I.II.III, etc etc)

thanks again FS!
dave

I've never run the total war pack, but I know some have.  Is it absolutely impossible to draft an ally in the Total War pack even if you want to, or does the DV shift just not get mucked up if you happen to draft an enemy as an ally?

-S'Cipio

The total war pack is intended for servers with no allies. If you use the regular missions you end up getting allied enemy ships (if that makes any sense.. lol), thus the total war pack... I'll give the new set a whirl on the Gravity Well tomorrow.

Thanks Dave!

[el-Karnak]

You see that topic? That's right. I really do think I've solved it. My tests show that I have.

Setup: 3 PCs. 1 as my own D2 server, and the other 2 as clients.
Time it took: Been trying all sorts of things since Tuesday..
Mission: Met_17PatrolEnemy  (found to cause it)

I'm sure some of you spotted the "Luc's Test Server" lately. This is what it was for.. and guess what, I think I fixed it.


Now, pay attention..
Anywhere you have a ship creation like this...

-------------------------------------
   mCreateShip( typeid( tAttackTeamShip ),
             shipScriptDescription.fClassName.c_str(),
             kStartPosition_W,
             shipScriptDescription.fMetaDatabaseID,
             gWC.fNWCustID++, 0, 0, -1, -1,
             shipScriptDescription.fCustomName.c_str(),
             static_cast<eShipOptions>( option | kCanBeCarrier | kStartPositionCanBeOffset ) );
-------------------------------------

.. you gotta find the file that handles the typeid.. (in this case, AttackTeamShip.cpp).
In there,  look for the mSetupState function and change it to something more restrictive:

-------------------------------------
void tAttackTeamShip::mSetupState()
{
   tTeamInfo* ti = fMissionInfo->mGetTeamHandle( mGetTeam() );
   if (ti)
   {
      if (! ( (!ti->mIsTeamHumanControlled()) && (!gScriptInterface.mIsHost()) ) )
      {
         mRegisterState( new tAttackTeamShipInitialState( ) );
         mGotoState( typeid( tAttackTeamShipInitialState ) );
      }
   }
}
-------------------------------------


Prevent NON-hosts from setting up the TeamState IF it's also an AI. If it's a player, you need the TeamState for the nonhost.


Now, I'm gonna try to compile as many missions as possible, but can someone get NuclearWessels and Karnak to see this? Thanks.

-- Luc

This code fix won't work for stand-alone AI creation routines like this:

void   mCreateShip( const type_info& ShipClass, int32 TotalBPV, eClassTypes SmallestHullSize, eClassTypes LargestHullSize, int32 VariantPercent, int32 Position, int32 CustomID, int32 StartX, int32 StartY, int32 EndX, int32 EndY, const char* CustomName, eShipOptions ShipOptions );

[FireSoul]

void   mCreateShip( const type_info& ShipClass, int32 TotalBPV, eClassTypes SmallestHullSize, eClassTypes LargestHullSize, int32 VariantPercent, int32 Position, int32 CustomID, int32 StartX, int32 StartY, int32 EndX, int32 EndY, const char* CustomName, eShipOptions ShipOptions );

Yes it does. ShipClass, the first parameter, is present. Here's the prototype of the function that I used in my example:

void   mCreateShip( const type_info& ShipClass, const char* ClassName, int32 Position, int32 MetaDatabaseID, int32 CustomID, int32 StartX, int32 StartY, int32 EndX, int32 EndY, const char* CustomName, eShipOptions ShipOptions );

All of the mCreateShip functions use it. Basically, you just have to figure out where the ShipClass used is located, and make sure only the host can register the TeamState for the AIs.

.. thankfully, the default ShipClass "typeid( tShipInfo )", which is hosted from within the API,  does not register a team state, so we don't have to worry about it.  That covers about all bases.

-- Luc

[Julin Eurthyr]

[EDIT: keeping in mind that I can't do much about Hexx ]

Couldn't you write a routine along the lines of:

If host=Hexx then
X=rand (100)
If X > 90 then fill map with T-bombs
endif
endif

And put it into every mission?       

Just a little reminder of what he'll have to face every mission with an ally...

[FireSoul]

[EDIT: keeping in mind that I can't do much about Hexx ]

Couldn't you write a routine along the lines of:

If host=Hexx then
X=rand (100)
If X > 90 then fill map with T-bombs
endif
endif

And put it into every mission?       

Just a little reminder of what he'll have to face every mission with an ally...

heh..

.. nope.. we don't have access to the player names, the current hex, or even the stardate.. sorry.
.. think! It woulda been done LONG ago!

[el-Karnak]

void   mCreateShip( const type_info& ShipClass, int32 TotalBPV, eClassTypes SmallestHullSize, eClassTypes LargestHullSize, int32 VariantPercent, int32 Position, int32 CustomID, int32 StartX, int32 StartY, int32 EndX, int32 EndY, const char* CustomName, eShipOptions ShipOptions );

Yes it does. ShipClass, the first parameter, is present. Here's the prototype of the function that I used in my example:

void   mCreateShip( const type_info& ShipClass, const char* ClassName, int32 Position, int32 MetaDatabaseID, int32 CustomID, int32 StartX, int32 StartY, int32 EndX, int32 EndY, const char* CustomName, eShipOptions ShipOptions );

All of the mCreateShip functions use it. Basically, you just have to figure out where the ShipClass used is located, and make sure only the host can register the TeamState for the AIs.

.. thankfully, the default ShipClass "typeid( tShipInfo )", which is hosted from within the API,  does not register a team state, so we don't have to worry about it.  That covers about all bases.

-- Luc

Nope. It does not work. The mCreateShip function is:

void   mCreateShip( const type_info& ShipClass, int32 TotalBPV, eClassTypes SmallestHullSize, eClassTypes LargestHullSize, int32 VariantPercent, int32 Position, int32 CustomID, int32 StartX, int32 StartY, int32 EndX, int32 EndY, const char* CustomName, eShipOptions ShipOptions );

Not the one you use in ::CreateNewShip function.

Try it out before you post next time, wonder-boy.

[Cleaven]

Try it out before you post next time, wonder-boy.

Nothing has changed. Not one single solitary thing.

[FPF-DieHard]

karnak, play nice. 

[FireSoul]

*sigh*

From the API, there are 4 mCreateShip functions. Here are their prototype, with the important bit in red.

TeamInfo.h:

   void   mCreateShip( const type_info& shipClass, const tShipInGame& ShipData);
   void   mCreateShip( const type_info& ShipClass, const char* ClassName, int32 Position, int32 MetaDatabaseID, int32 CustomID, int32 StartX, int32 StartY, int32 EndX, int32 EndY, const char* CustomName, eShipOptions ShipOptions ); // The only one used
   void   mCreateShip( const type_info& ShipClass, int32 TotalBPV, eClassTypes ShipType, int32 VariantPercent, int32 Position, /*int32 MetaDatabaseID,*/ int32 CustomID, int32 StartX, int32 StartY, int32 EndX, int32 EndY, const char* CustomName, eShipOptions ShipOptions, eRace Race = kNoRace );

   void   mCreateShip( const type_info& ShipClass, int32 TotalBPV, eClassTypes SmallestHullSize, eClassTypes LargestHullSize, int32 VariantPercent, int32 Position, int32 CustomID, int32 StartX, int32 StartY, int32 EndX, int32 EndY, const char* CustomName, eShipOptions ShipOptions );

They all use the shipClass param which allows you to define your own ShipInfo code. Within the ShipInfo file is where the problem is, so the issue is not[/red] the mCreateShip function.

But I'll play along. 

• The first mCreateShip listed here, above, calls mCreateTeamShip to do the final work.
• The 2nd comes from my original example. It also  calls mCreateTeamShip to do the final work
• The 3rd comes from your complaint. Within the API I see that that one calls
  mCreateFleet, which in turn calls mCreateTeamFleet, which in turn calls mCreateTeamShip within its loop.
• The 4th mCreateShip also calls mCreateFleet, and follows the same path as the 3rd one.

So. They all use the parameter which defines the shipClass to use. You use that to track down the bug within the source, where the Registeration of TeamState is, and you make it more restrictive to prevent the double-fighters/weapons.. .. and they all end up within the same function of the API.

I would like to point out that other functions, such as mCreateTeamFleet and mCreateCPUFleet, also do this.


Edit: Oh! NOTE:
If you're Registering the TeamState elsewhere, for whatever reason you need to do this, then you need to add the restriction that only the host should Register that State for the AI ships. The focus is the State: make sure it's not run on all machines.

[FireSoul]

*back from shower* ..

.. forget about the mCreateShips. You just need some focus towards the goal.

Just locate everywhere the Team States are being registered, and prevent non-hosts from registering the state for AI teams. The mCreateShip functions will help you find these, and that was stated in the first post.

It can be anywhere in the code that can access functions in the ShipInfo class. It is possible to register a new state from within a state overriding to original one.